Enhance package-extractor: batch folder collection and add hoisting skip option#5758
Open
Enhance package-extractor: batch folder collection and add hoisting skip option#5758
Conversation
…ueue and add pnpmNodeModulesHoistingEnabled option Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/483711d5-f1e0-4f69-b1b1-445230d9c33f Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/483711d5-f1e0-4f69-b1b1-445230d9c33f Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
dmichon-msft
April 8, 2026 23:46
View session
dmichon-msft
requested review from
apostolisms,
bmiddha,
dmichon-msft,
iclanton,
jxanthony and
octogonz
as code owners
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/bdcb8673-e8f6-480c-a999-44737579f43f Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
dmichon-msft
approved these changes
Apr 10, 2026
iclanton
approved these changes
Apr 11, 2026
| "changes": [ | ||
| { | ||
| "packageName": "@rushstack/package-extractor", | ||
| "comment": "Update _collectFoldersAsync to process all starting folders in a single shared queue instead of serially. Add pnpmNodeModulesHoistingEnabled option to IExtractorSubspace to skip virtual store hoisting lookup when hoisting is disabled.", |
Member
There was a problem hiding this comment.
Suggested change
| "comment": "Update _collectFoldersAsync to process all starting folders in a single shared queue instead of serially. Add pnpmNodeModulesHoistingEnabled option to IExtractorSubspace to skip virtual store hoisting lookup when hoisting is disabled.", | |
| "comment": "Update `_collectFoldersAsync` to process all starting folders in a single shared queue instead of serially. Add `pnpmNodeModulesHoistingEnabled` option to `IExtractorSubspace` to skip virtual store hoisting lookup when hoisting is disabled.", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_collectFoldersAsyncand hoisting logic_collectFoldersAsyncto accept an array of starting folders and use a single sharedAsyncQueueinstead of being called serially per projectpnpmNodeModulesHoistingEnabledoption toIExtractorSubspaceto control whether to look for hoisted packages in the pnpm virtual store